fix typos per issue 969 #979
Conversation
|
Hi @qhaas! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
My employer (Oak Ridge National Laboratory) has reached out to |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Why not merge this? The bug/typo is definitely present and should be fixed.
I imagine that some scrutineering is required to make sure that what CI/CD is producing does not change unexpectedly (that is if they use build_all_docker.sh at all, which we don't really know).
As described in this comment of issue 969, it appears two different typos (
MANYLINUX_VERSIONvsMANY_LINUX_VERSIONandMANY_LINUX_VERSIONvsMANY_LINUX_VERSON) hid the fact the environment variableMANYLINUX_VERSIONwas being ignored anddocker.io/pytorch/manylinux-builderis built instead of the expecteddocker.io/pytorch/manylinux2014-builderwhen2014is set.MANY_LINUX_VERSIONis assumed to be the intended variable name.